[U-Boot] [PATCH 1/2] i.MX28: Fix ref_cpu clock setup
Robert Deliën
robert at delien.nl
Fri Feb 3 11:32:14 CET 2012
Hi Fabio,
> Very good, Robert! I tested your patch and it fixes the reboot issue
> on my mx28evk.
You're most welcome! I'm glad to hear it fixes your problem too.
> Also checked in the MX28 Reference Manual about the fact that
> hw_clkctrl_frac0 can only be accessed as bytes.
It's easy to overlook, I have to admit.
> I have some suggestions though:
>
> 1. Your patch comes as attachment. Please use git send-email instead.
I knew I was violating protocol, but I wanted to get it off my chest. I will
work on this problem today. I work at two locations, and only at my home
office I have an SMTP server I can user. Here at Agilent, unfortunately I
only have an MS Exchange server I can use. If I can get that configured
at all, there's a good chance it will break my patches.
> 2. Please grep the locations where hw_clkctrl_frac0 is assigned as
> 32-bit and change those as well.
Will do!
> 3. Send the two patches in a series via git send-email: 1/2 and 2/2
Will do! I'm reading up on that right now, as Wolfgang suggested
earlier. I may as well switch our own internal repository from SVN
to GIT, but not today.
> Good to know that you fixed the stepping issue as well. Good work!
Thanks. I would really like to urge you guys to test the second patch
as well. Marek made a remark on that too, so that will be my next mail
to answer.
Cheers,
Robert.
More information about the U-Boot
mailing list