[U-Boot] [PATCH 10/28] net: cosmetic: Improve variable names and code readability

[Mike Frysinger]

On Tuesday 24 January 2012 01:19:14 Simon Glass wrote:
> On Thu, Jan 19, 2012 at 4:53 PM, Joe Hershberger wrote:
> > Rename parameter len to payload_len in NetSendUDPPacket: this name
> >   more explicitly claims that it does not include the header size
> > Rename CDPHandler to CDPReceive: this is not called as a handler,
> >   so don't name it that way
> > Rename OPT_SIZE to OPT_FIELD_SIZE: clearer constant name and also
> >   remove related BOOTP_SIZE which was unused and doesn't take into
> >   account VLAN packets
> > Rename tmp to reply_ip_addr in arp.c
> > Alphabetize includes in net.c
> > Replace magic numbers in arp.c with constants
> > Add a more explicit comment about 802.2
> 
> Yes but why lump all of these together? It would benefit from 3-4
> separate commits IMO.

+1
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120203/4e4d7049/attachment.pgp>