[U-Boot] [PATCH 13/28] net: Refactor bootp packet length computations

Mike Frysinger vapier at gentoo.org
Fri Feb 3 13:13:35 CET 2012


On Tuesday 24 January 2012 02:15:41 Joe Hershberger wrote:
> On Tue, Jan 24, 2012 at 1:05 AM, Simon Glass wrote:
> > On Thu, Jan 19, 2012 at 4:53 PM, Joe Hershberger wrote:
> >> -       debug("Transmitting DHCPREQUEST packet: len = %d\n", pktlen);
> >>  #ifdef CONFIG_BOOTP_DHCP_REQUEST_DELAY
> >>        udelay(CONFIG_BOOTP_DHCP_REQUEST_DELAY);
> >>  #endif /* CONFIG_BOOTP_DHCP_REQUEST_DELAY */
> >> +       debug("Transmitting DHCPREQUEST packet: len = %d\n", pktlen);
> > 
> > Did you move this on purpose?
> 
> Yes... I figured a transmit debug message should be close to the
> transmit... not before a delay.

generally we frown on these sort of side-commits ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120203/f4015037/attachment.pgp>


More information about the U-Boot mailing list