[U-Boot] [PATCH 2/2] i.MX28: Fix ref_cpu clock setup

[Marek Vasut]

> Hi,
> 
> > this is how the imx-bootlets does it though. It's likely that FSL wants
> > the PLL0 to run from XTAL when doing power configuration?
> 
> I was using the FLS bootlets as a reference too, but I have noticed a
> number of 'mistakes' in that code. For example:
> - Busy-indicators aren't considered when reconfiguring PLLs
> - They are linked right on top of the expection vectors
> - Sloppy printf macros left out <CR>s

Do you know why we use our own implementation of the boot code instead of imx 
bootlets? ;-)

> So for me it's more of a best effort example than a Reference.
> And personally, I'd rather have the CPU running from a rock-solid - yet
> slower - xtal, than a sensitive PLL0 when I start tickering with power
> supplies.

If you can guarantee the CPU won't go insane during some power transition when 
running from xtal, then it's fine by me. Then it makes me wonder though, why FSL 
switched to PLL.
> 
> > Maybe clock2pll should be fixed then ?
> 
> That's how I started. But properly configuring PLL0 also requires to
> properly configure EMI, or the board will hand. And this is exactly what
> is done in mx28_mem_init_clock.
> 
> clock2pll is broken: It disables PLL bypass without configuring PLL0 first,
> or even ungating it. I don't fully understand why it works in normal
> operation. Perhaps due to some bus-lag.

Fabio?
> 
> I think it is justified to remove it, because what it intends to do, is
> done slightly later by mx28_mem_init_clock. I think FSL reused/shares this
> code with other platforms, where no mx28_mem_init_clock is present, but in
> that case they do have a bug to fix.
> 
> Cheers,
> 
>         Robert.

Thanks

M