[U-Boot] [PATCH] arm: Add option to disable code relocation

Graeme Russ graeme.russ at gmail.com
Mon Feb 6 09:43:00 CET 2012


Hi Wolfgang,

On 02/06/2012 06:51 PM, Wolfgang Denk wrote:
> Dear Graeme Russ,
> 
> In message <CALButC+==qGs5EaAHtQqU4zEjqvg-3187eWaqU-fv3dWp5QQ7w at mail.gmail.com> you wrote:
>>
>> I think the immediate focus should be on centralising the init sequence
>> processing into /common/init.c and then bringing the new'initcall'
>> architecture online
> 
> Agreed.
> 
>> Once these have been done, any board can just specific:
>>
>> SKIP_INIT(RELOC)
> 
> I will probably object to his, too - for the same reasons.

Considering this is a 'free' artefact of how the init sequence functions,
and that it is board specific and totally non-invasive for anyone else
(i.e. no ugly ifdef's anywhere else in the code) I'm surprised you would
object...

It would be like a board not populated with USB hardware on a arch that
globally defines it saying SKIP_INIT(USB) to avoid linking in the USB
initialisation (maybe not the best example, but you get the point)

Or if a pre-loader initialises SDRAM the board can specify SKIP_INIT(SDRAM)

The point is we can specify a 'standard' set of init 'components' and
boards can trivially disable any of these components as they see fit with
zero impact on any other part of the U-Boot code base

And they can add their own init components, again with zero impact on the
U-Boot code base

Regards,

Graeme


More information about the U-Boot mailing list