[U-Boot] [PATCH 1/2] v2 i.MX28: Fix ref_cpu clock setup
Marek Vasut
marek.vasut at gmail.com
Mon Feb 6 14:15:44 CET 2012
> Hi,
>
> > That's why I put the ternary operator there ?
>
> Ah; without anything behind it, it really just looked like a question mark.
> But using a ternary caters only for a set of two. So enumeration would
> be better ideed.
>
> > It's impossible to review like this though and much more prone to pull in
> > bugs.
>
> Can you point me to a good and tutorial for GIT then? Just a brief
> description of the work flow, from cloning the public archive, to
> submitting patches with a couple of examples.
I just sent you an howto in a subsequent mail.
>
> Now, for every bit of rework, I clone a new archive and manually
> patch in all my changes to make a clean patch.
No, it's really simple, see the email.
> That is two hours of work
> and I'm not willing to spend that time on every remark.
Yep ... basically, you need to learn:
git rebase -i (select patches you want to edit, reword ...)
git commit --amend (add stuff to top-of-head patch)
And the stuff I sent you -- "git reset" to reset changes from the index, git add
-p to add changes selectively.
M
>
> Cheers,
>
> Robert.
More information about the U-Boot
mailing list