[U-Boot] http://patchwork.ozlabs.org/patch/136415/ seems to break HUSH parser?

[Stefano Babic]

On 06/02/2012 23:43, Albert ARIBAUD wrote:
> Hi,
> 

Hi Albert,

> Some time ago I have posted http://patchwork.ozlabs.org/patch/136368/
> which adds HUSH parser to ED Mini V2. In itself, the change is only made
> of three CONFIG defines.
> 
> This patch has built cleanly and worked as expected until
> http://patchwork.ozlabs.org/patch/136415/ was applied. Applying both
> patches causes edminiv2 build to fail with
> 
> uboot at lilith:~/src/u-boot-arm$ ./MAKEALL edminiv2
> Configuring for edminiv2 board...
> common/libcommon.o: In function `cread_line':
> /home/uboot/src/u-boot-arm/common/main.c:717: undefined reference to
> `get_ticks'
> /home/uboot/src/u-boot-arm/common/main.c:717: undefined reference to
> `get_tbclk'
> /home/uboot/src/u-boot-arm/common/main.c:720: undefined reference to
> `get_ticks'

This is not a problem in your patch, but some SOCs have no
implementation of the new and now accepted iunterface. I have sent
patches for i.MX35/i.mx5/i.mx31:
	http://patchwork.ozlabs.org/patch/139718/

I have seen that other SOCs have the same issue, while kirchwood has
introduced an empty implementation for such functions. We should fix all
remaining arch.

Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================