[U-Boot] [PATCH] bugfix: all Marvell specific build fails due to undefined reference to `get_ticks'

Prafulla Wadaskar prafulla at marvell.com
Wed Feb 8 08:03:50 CET 2012



> -----Original Message-----
> From: Graeme Russ [mailto:graeme.russ at gmail.com]
> Sent: 08 February 2012 11:00
> To: Prafulla Wadaskar
> Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik
> Subject: Re: [U-Boot] [PATCH] bugfix: all Marvell specific build fails
> due to undefined reference to `get_ticks'
> 
> Hi Prafulla,
> 
> On Wed, Feb 8, 2012 at 7:49 PM, Prafulla Wadaskar
> <prafulla at marvell.com> wrote:
> > after http://patchwork.ozlabs.org/patch/136415/ was applied. All
> Marvell
> > build fails with below error
> >
> > common/libcommon.o: In function `cread_line':
> > /home/uboot/src/u-boot-arm/common/main.c:717: undefined reference to
> `get_ticks'
> > /home/uboot/src/u-boot-arm/common/main.c:717: undefined reference to
> `get_tbclk'
> > /home/uboot/src/u-boot-arm/common/main.c:720: undefined reference to
> `get_ticks'
> >
> > The same is fixed for Kirkwood, ARMADA100, pantheon and orion5x SoCs
> >
> > Signed-off-by: Prafulla Wadaskar <prafulla at marvell.com>
> 
> > +ulong get_tbclk (void)
> > +{
> > +       ulong tbclk;
> > +
> > +       tbclk = CONFIG_SYS_HZ;
> > +       return tbclk;
> > +}
> 
> Why not "return CONFIG_SYS_HZ;'" or "return (ulong)CONFIG_SYS_HZ;" ?

Thanks, good idea, actually the code was simply copy paste from other ARM implementation :)
I will do it for v2

Regards..
Prafulla . . .


More information about the U-Boot mailing list