[U-Boot] [PATCH 1/5] mx53loco: Use gpio_direction_input prior to gpio_get_value

[Stefano Babic]

On 08/02/2012 13:34, Fabio Estevam wrote:
> Use gpio_direction_input prior to gpio_get_value.
> 
> Cc: Jason Liu <r64343 at freescale.com>
> Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
> ---
>  board/freescale/mx53loco/mx53loco.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 

Hi Fabio,

> diff --git a/board/freescale/mx53loco/mx53loco.c b/board/freescale/mx53loco/mx53loco.c
> index e6345e7..c2c26f0 100644
> --- a/board/freescale/mx53loco/mx53loco.c
> +++ b/board/freescale/mx53loco/mx53loco.c
> @@ -153,7 +153,9 @@ int board_mmc_getcd(struct mmc *mmc)
>  	int ret;
>  
>  	mxc_request_iomux(MX53_PIN_EIM_DA11, IOMUX_CONFIG_ALT1);
> +	gpio_direction_input(75);
>  	mxc_request_iomux(MX53_PIN_EIM_DA13, IOMUX_CONFIG_ALT1);
> +	gpio_direction_input(77);
>  

The patch makes clear that the GPIO is configured as input. However,
after a reset all GPIOs in the MX53 are configured as input. Do we need
such changes ?

Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================