[U-Boot] [PATCH 17/28] net: Refactor to separate the UDP handler from the ARP handler

Joe Hershberger joe.hershberger at gmail.com
Wed Feb 8 23:52:54 CET 2012


Hi Mike,

On Fri, Feb 3, 2012 at 6:21 AM, Mike Frysinger <vapier at gentoo.org> wrote:
> On Thursday 19 January 2012 19:53:20 Joe Hershberger wrote:
>> Only call the handlers if one was registered... don't require
>>    protocols to register a handler (eliminating dummies)
>> NetConsole now uses the ARP handler when waiting on arp (instead of
>>    needing a #define hack in arp.c)
>> Clear handlers at the end of net loop
>
> what if the SetHandler funcs took care of setting to a dummy func when it was
> given NULL ?  then calling code need not worry about creating their own
> dummies, and you don't have to add NULL pointer checking.

The calling code doesn't create dummies any longer.  That is the point
of the NULL checking.  Do you prefer the set method register a dummy
instead of a NULL check?

-Joe


More information about the U-Boot mailing list