[U-Boot] [PATCH 2/2] mx6qsabrelite: add and enable USB Host 1 support

[Dirk Behme]

Hi Wolfgang,

On 08.02.2012 16:23, Wolfgang Grandegger wrote:
> Cc: Stefano Babic <sbabic at denx.de>
> Cc: Jason Liu <jason.hui at linaro.org>
> Signed-off-by: Wolfgang Grandegger <wg at denx.de>
> ---
>  board/freescale/mx6qsabrelite/mx6qsabrelite.c |   12 ++++++++++++
>  include/configs/mx6qsabrelite.h               |   15 +++++++++++++++
>  2 files changed, 27 insertions(+), 0 deletions(-)
> 
> diff --git a/board/freescale/mx6qsabrelite/mx6qsabrelite.c b/board/freescale/mx6qsabrelite/mx6qsabrelite.c
> index 4028789..01ecec4 100644
> --- a/board/freescale/mx6qsabrelite/mx6qsabrelite.c
> +++ b/board/freescale/mx6qsabrelite/mx6qsabrelite.c
> @@ -77,6 +77,18 @@ static void setup_iomux_uart(void)
>         imx_iomux_v3_setup_multiple_pads(uart2_pads, ARRAY_SIZE(uart2_pads));
>  }
>  
> +#ifdef CONFIG_USB_EHCI_MX6
> +int board_ehci_hcd_init(int port)
> +{
> +	imx_iomux_v3_setup_multiple_pads(usb_pads, ARRAY_SIZE(usb_pads));

Where is the definition of 'usb_pads'?

mx6qsabrelite.c: error: 'usb_pads' undeclared (first use in this function)

> +	/* Reset USB hub */
> +	gpio_direction_output(204, 0); /* GPIO 7-12 */

With

http://git.denx.de/?p=u-boot/u-boot-imx.git;a=commitdiff;h=7861b0f3eb638df23b992f89229c3b416634b6fa

we might want to use something like

gpio_direction_output(GPIO_NUMBER(7, 12), 0);

?

Same below for gpio_set_value() ?

> +	mdelay(2);
> +	gpio_set_value(204, 1);
> +}

mx6qsabrelite.c: warning: no return statement in function returning non-void

Best regards

Dirk