[U-Boot] [PATCH 09/28] net: cosmetic: Un-typedef variables in net

[Joe Hershberger]

Hi Mike,

On Fri, Feb 3, 2012 at 6:05 AM, Mike Frysinger <vapier at gentoo.org> wrote:
> On Thursday 19 January 2012 19:53:12 Joe Hershberger wrote:
>> Un-typedef IP_t, Ethernet_t, VLAN_Ethernet_t, ARP_t, ICMP_t
>
> i'm not sure about this.  i don't mind the typedefs myself and they have the
> advantage of already being done ... let's see what Wolfgang prefers.

Wolfgang was clearly against typedef'ed structs when I asked him in
October of last year.

On Thu, Oct 13, 2011 at 3:36 PM, Wolfgang Denk <wd at denx.de> wrote:
> In message <CANr=Z=bmm64Qxv+Zpc=GShY7c2KapAgh9xm-cq79TM1oQ76V5A at mail.gmail.com> you wrote:
>>
>> WARNING:NEW_TYPEDEFS: do not add new typedefs
>> This seems rather limiting... I'm not sure why even Linux would want
>> this, at least when it applies to typedefs of structs.  It makes sense
>> if it's a new typedef for int or something.
>
> See the CodingStyle, start reading at "It's a _mistake_ to use typedef
> for structures and pointers."

That's why I didn't leave them to be complained about by checkpatch.

-Joe