[U-Boot] [PATCH] fw_env.c: use default env values if config file cannot be opened

[Wolfgang Denk]

Dear Frans,

In message <CACW_hTY4oqT8bBGTkTopiX=rNpCmG50rNXWY0AfydAX3wZj5Rg at mail.gmail.com> you wrote:
> 
> > As you mentioned in another reply the common practice nowadays seems to be
> to use a conf file.
> This has the disadvantage that the conf file can get lost or misplaced.

True.  And this is an error situation, for wich a proper error message
should be issued, and execution terminated.

Paperingover such a bug is IMHO a very bad idea.

> BTW: it could also be argued that the specification of the config file
> should be in the board config, not in fw_env.h.

Yes, that could be argued.  But this is unrelated tot his patch.

I still tend to reject it.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
That was the thing about deserts. They had their  own  gravity.  They
sucked you into the centre.           - Terry Pratchett, _Small Gods_