[U-Boot] [PATCH 2/5] mx35pdk: Provide proper range for memtest

[Stefano Babic]

On 12/02/2012 16:38, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam at freescale.com>
> 
> memtest adresses should contain proper DRAM address range.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
> ---
>  include/configs/mx35pdk.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/configs/mx35pdk.h b/include/configs/mx35pdk.h
> index 0c62b9f..f2d4112 100644
> --- a/include/configs/mx35pdk.h
> +++ b/include/configs/mx35pdk.h
> @@ -156,8 +156,8 @@
>  #define CONFIG_SYS_MAXARGS	16	/* max number of command args */
>  #define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE /* Boot Argument Buffer Size */
>  
> -#define CONFIG_SYS_MEMTEST_START	0	/* memtest works on */
> -#define CONFIG_SYS_MEMTEST_END		0x10000
> +#define CONFIG_SYS_MEMTEST_START	(PHYS_SDRAM_1 + PHYS_SDRAM_1_SIZE/2)
> +#define CONFIG_SYS_MEMTEST_END		(PHYS_SDRAM_1 + PHYS_SDRAM_1_SIZE)
>  
>  #undef	CONFIG_SYS_CLKS_IN_HZ	/* everything, incl board info, in Hz */
>  
Personally I do not like that the memory test runs taking automatically
the input parameters - even if the test must run automatically, I think
it is better to put the parameters inside a script else to compile them
with U-Boot.

But if we want to change them, why to put the start address at the
middle of RAM ? The mx35pdk can have two banks of RAM, and the second
one will still not tested. What I mean is that it is quite arbitrary
where to set CONFIG_SYS_MEMTEST_START and CONFIG_SYS_MEMTEST_END, and
with the possibility on some boards to have different RAM configurations
this setup should be not decided at compile time.

And setting the end of test at the end of RAM (but this can open a
debate: really the RAM size is computed at runtime with get_ram_size())
will overwrite U-Boot.

Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================