[U-Boot] SRIO patches

Andy Fleming afleming at gmail.com
Mon Feb 13 09:09:41 CET 2012


I'm afraid I deleted the SRIO patch emails before I knew I needed to
keep them, so I'm just going to summarize my comments in this email.

1) I'm not convinced we need a "MASTER" build target. Isn't it
possible to just add support for serving as an SRIO master, and to
enable support from the command line, or via environment variable?

2) There are a number of constants being defined that seem very much
like system options (ie something that will vary with different
chips):


+#define SRIO_PORT_MAX_NUM	2	/* SRIO port max number */
+#define SRIO_OB_WIN_NUM	9	/* SRIO outbound window number */
+#define SRIO_IB_WIN_NUM	5	/* SRIO inbound window number */
+#define SRIO_MSG_UNIT_NUM		2	/* SRIO message unit number */


Maybe these should be config options?

Andy


More information about the U-Boot mailing list