[U-Boot] [PATCH v2 2/6] config.mk: Make cc-option create a file under include/generated

[Mike Frysinger]

On Monday 13 February 2012 18:02:02 Tom Rini wrote:
> isnt possible with /dev/null.

isn't

> --- a/config.mk
> +++ b/config.mk
>
> -cc-option-sys = $(shell if $(CC) $(CFLAGS) $(1) -S -o /dev/null -xc /dev/null \
> -		> /dev/null 2>&1; then \
> +cc-option-sys = $(shell mkdir -p $(dir $(CC_TEST_FILE)); \
> +		touch $(CC_TEST_FILE); \
> +		if $(CC) $(CFLAGS) $(1) -S -o $(CC_TEST_FILE) \
> +		-xc $(CC_TEST_FILE) > /dev/null 2>&1; then \

why do you need to touch the file first ?  why do you source this test file
instead of continuing to source /dev/null ?  don't you run into problems if
you use cc-option-sys more than once and a previous run wrote something to
that file ?  then cc-option-sys could fail on later runs ...

seems like you should drop the `touch` and keep the -xc /dev/null and only
change the -o to $(CC_TEST_FILE) ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120214/374a52b7/attachment.pgp>