[U-Boot] [PATCH v2 1/8] sandbox: fdt: Add support for CONFIG_OF_CONTROL

[Simon Glass]

Hi Mike,

On Sun, Jan 22, 2012 at 11:32 PM, Mike Frysinger <vapier at gentoo.org> wrote:

> On Monday 23 January 2012 00:27:56 Simon Glass wrote:
> > On Fri, Jan 20, 2012 at 10:54 AM, Mike Frysinger wrote:
> > > On Tuesday 10 January 2012 19:45:45 Simon Glass wrote:
> > >> This adds support for a controlling fdt, mirroring the ARM
> > >> implementation.
> > >
> > > OK, but what's the point if we aren't doing FDT's ?
> >
> > Aren't we?
>
> i don't see FDT's getting used anywhere in this patch or this patch series.
> so no, we aren't currently doing FDT's in sandbox.
>

I have a patch which tests fdtdec and this uses FDT support in Sandbox. I
don't see any reason to have it turned off - it's just a pain for people to
turn it on.


>
> > I hope that sandbox provides a way of testing the FDT
> > stuff. I used it for the fdtdec alias stuff which was complicated
> > enough that it needed unit tests.
>
> if it actually can be used/tested under sandbox, then i'm fine with this.
>  but
> can that actually be done now or are other things necessary first ?
>

It can be done now - it works fine as is.


>
> > We need to enable these options to bring in that code, even if we don't
> > actually have a run-time FDT yet.
>
> i don't see how run-time FDT's would be used by sandbox ...
>

Well they could be used to configure the SPI flash driver, instead of
command line, for example. But that's a separate issue. Really I just want
to have the feature enabled so that the code is compiled in.

Regards,
Simon



> -mike
>