[U-Boot] [PATCH v2] sh: i2c: Add support I2C controller of SH7734

Heiko Schocher hs at denx.de
Wed Feb 15 08:54:33 CET 2012


Hello Nobuhiro,

Nobuhiro Iwamatsu wrote:
> Renesas SH7734 has two I2C interfaceis.
> This supports these I2C.
> 
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj at renesas.com>
> ---
> V2: - Changed bit control to use the clr|set|clrsetbits_* functions.
>     - Fix wrong comment style.
> 	- Add new line before for loop in i2c_read.
> 
>  drivers/i2c/Makefile        |    1 +
>  drivers/i2c/sh_sh7734_i2c.c |  445 +++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 446 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/i2c/sh_sh7734_i2c.c

[hs at pollux u-boot]$ ./tools/checkpatch.pl index.html
ERROR: trailing whitespace
#238: FILE: drivers/i2c/sh_sh7734_i2c.c:193:
+^Isetbits_8(&base->iccr2, SH_I2C_ICCR2_IICRST);^I$

total: 1 errors, 0 warnings, 452 lines checked

NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
      scripts/cleanfile

NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE

index.html has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
[hs at pollux u-boot]$

Beside of that, I Ack this patch only, so you can pick it up in your
u-boot-sh.git tree, because it is dependend on the following patch
from you:

sh: Add bit control functions
http://patchwork.ozlabs.org/patch/141259/

If this is Ok for you, please add my:

Acked-by: Heiko Schocher <hs at denx.de>

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


More information about the U-Boot mailing list