[U-Boot] [PATCH] sh: Add bit control functions

Heiko Schocher hs at denx.de
Wed Feb 15 08:56:25 CET 2012


Hello Nobuhiro,

Nobuhiro Iwamatsu wrote:
> This provide bit control functions as clrbits_*, setbits_* and
> clrsetbits_*.
> 
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj at renesas.com>
> ---
>  arch/sh/include/asm/io.h |   37 +++++++++++++++++++++++++++++++++++++
>  1 files changed, 37 insertions(+), 0 deletions(-)

Beside one minor comment:

Acked-by: Heiko Schocher <hs at denx.de>

> diff --git a/arch/sh/include/asm/io.h b/arch/sh/include/asm/io.h
> index ca598a6..79cb098 100644
> --- a/arch/sh/include/asm/io.h
> +++ b/arch/sh/include/asm/io.h
> @@ -237,6 +237,43 @@ static inline void sync(void)
>  {
>  }
>  
> +
> +/* Clear and set bits in one shot. These macros can be used to clear and

Wrong comment style, please fix.

[...]

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


More information about the U-Boot mailing list