[U-Boot] [PATCH] Elimintated magic numbers for scratch register addresses

[Robert Deliën]

Is this patch approved?

________________________________________
From: u-boot-bounces at lists.denx.de [u-boot-bounces at lists.denx.de] on behalf of Robert Deliën [robert at delien.nl]
Sent: 07 February 2012 10:15
To: Marek Vasut
Cc: u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH] Elimintated magic numbers for scratch register    addresses

> > +     uint32_t        hw_digctl_writeonce;                    /* 0x060 */
> > +     uint32_t        reserved_writeonce[3];
>
> Just mark all this crap as "reserved" and be done with it.

If that's good enought, that will save me some work next time.

> > +     uint32_t        hw_digctl_dbg;                          /* 0x0e0 */
> > +     uint32_t        reserved_hw_digctl_dbg[3];
> > +
> > +     uint32_t        reserved2[4];
>
> Just like this :)

I copied it from how it's done in regs-power.h: "Reserverd" for whole
areas not being used, "reserved_name[3]" where one might expect to
find a set, clear and toggle register.

> Yep, looks fine.
>
> btw you don't have to send a cover letter for a single patch.

The cover letter was an accident. I'm still in the process of learning how git
send-email works. There's a lot of clever things in there, working for you if
you know how it works, but against you if you don't.

> Though this series
> should contain a subsequent patch that'll fix all usage of DIGCTL registers.

Nobody was using DICTL registers yet. I could have sent the magic address
repair (where macros are replaced with registers defined here) as a separate
patch but I didn't expeact that to be necessary.
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot