[U-Boot] [PATCH] net: sh_eth: Fix build warnings and whitespace for sh_eth

[Mike Frysinger]

On Wednesday 15 February 2012 02:51:40 Nobuhiro Iwamatsu wrote:
> 2012/2/3 Mike Frysinger:
> > On Friday 03 February 2012 02:30:48 Nobuhiro Iwamatsu wrote:
> >>  static int sh_eth_bb_set_mdc(struct bb_miiphy_bus *bus, int v)
> >>  {
> >> +     int port;
> >>       struct sh_eth_dev *eth = bus->priv;
> >> -     int port = eth->port;
> >> +
> >> +     port = eth->port;
> >> 
> >>       if (v)
> >>               outl(inl(PIR(port)) | PIR_MDC, PIR(port));
> > 
> > i don't see why any of these changes are necessary ... the old code looks
> > fine to me (from a warning and style pov)
> 
> I do not seem to have any problem with the former cord, too either.
> But when I dont apply this patch, I get the following warning.
>
> sh_eth.c: In function ‘sh_eth_bb_set_mdc’:
> sh_eth.c:611: warning: unused variable ‘port’

you've got a different problem then and modifying the sh_eth driver ignores it

what board are you building for exactly ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120215/d96245aa/attachment.pgp>