[U-Boot] [PATCH v4 4/9] Stop using builtin_run_command()

Simon Glass sjg at chromium.org
Wed Feb 15 23:15:18 CET 2012


Hi Michael,

On Wed, Feb 15, 2012 at 11:44 AM, Michael Walle <michael at walle.cc> wrote:
> Am Mittwoch 15 Februar 2012, 07:05:24 schrieb Simon Glass:
>> Unfortunately I think that this approach is a little broken. We are running
>> a command sequence from getenv(), but while processing it, we might update
>> the environment variable. Worse, we actually overwrite the newlines in the
>> variable as we process it.
> Isn't it as easy as copying the current content and processing that instead?

Yes, that's what I have done - but it is not trivial so did not try to
bring it into the old series.

Regards,
Simon

>
>
> --
> Michael


More information about the U-Boot mailing list