[U-Boot] [PATCH v3 7/8] sandbox: Add flags for open() call

[Simon Glass]

Hi Mike,

On Tue, Jan 24, 2012 at 1:45 PM, Mike Frysinger <vapier at gentoo.org> wrote:
> On Monday 23 January 2012 01:48:52 Simon Glass wrote:
>> This provides a way for callers to create files for writing. We define
>> flags which mirror the POSIX values.
>
> there are no POSIX values, just names.  the way the defines get interpreted is
> left up to implementations.
>
>> @@ -19,11 +24,7 @@
>>   * MA 02111-1307 USA
>>   */
>>
>> -/*
>> - * Operating System Interface
>> - *
>> - * This provides access to useful OS routines from the sandbox
>> architecture - */
>> +struct sandbox_state;
>
> looks like unrelated stuff got squished into here

We need to declare the struct. The comment change is because you said
we should put the purpose of the file at the top, and I thought it
didn't really warrant a new commit?

>
>> +#define OS_O_RDONLY  0
>> +#define OS_O_WRONLY  1
>> +#define      OS_O_RDWR       2
>> +#define OS_O_CREAT   0100
>
> seems to be whitespace mismatch between "#define" and the actual define.  some
> use tabs and some spaces ?
> -mike

Fixed.

Regards,
Simon