[U-Boot] [PATCH 2/2] Allow newlines within command environment vars

[Simon Glass]

Hi Wolfgang,

On Wed, Feb 15, 2012 at 2:49 PM, Wolfgang Denk <wd at denx.de> wrote:
> Dear Simon Glass,
>
> In message <CAPnjgZ0XueZukodaNSdQSYvuevyiH5Z-=3-2pkcC7OekddG-JA at mail.gmail.com> you wrote:
>>
>> > In message <1329286030-32560-2-git-send-email-sjg at chromium.org> you wrote:
>> > > The environment variables preboot, bootcmd and menucmd can hold a command
>> > > to execute. This change permits these variables to have newlines so that
>> > > they work the same as the 'source' command.
>> > >
>> > > Signed-off-by: Simon Glass <sjg at chromium.org>
>> > > ---
>> > >  common/main.c |    6 +++---
>> > >  1 files changed, 3 insertions(+), 3 deletions(-)
>> >
>> > Please squash this into the patch that introduces run_command_list()
>> > [assuming this is the patch which breaks behaviour?]
>> >
>>
>> The first patch is just a clean-up and should not change any behaviour.
>> This second patch changes the behaviour of the named env variables.
>
> So which commit introduced the breakage, then?

Which breakage are you referring to? The intent of these two patches
is to add a new feature (proposed by Michael Walle <michael at walle.cc>
who also provided a patch) on top of the command refactor series.

Sorry, there is some confusion here but I'm not sure what it is.

Regards,
Simon
>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> A stone was placed at a ford in a river with the inscription:
> "When this stone is covered it is dangerous to ford here."