[U-Boot] [PATCH] command, log: print with "log show" a full logbuffer

Detlev Zundel dzu at denx.de
Fri Feb 17 16:07:53 CET 2012


Hi Heiko,

> If the logbuffer contains LOGBUFF_LEN chars, they never got
> printed with the "log show" command, because chars get
> printed with the following for loop:
>
> for (i = 0; i < (size & LOGBUFF_MASK); i++) {
>
> with size = LOGBUFF_LEN and LOGBUFF_MASK = (LOGBUFF_LEN-1)
> for loop never executed ...
>
> Fix this.
>
> Signed-off-by: Heiko Schocher <hs at denx.de>

Indeed a good catch!

Acked-by: Detlev Zundel <dzu at denx.de>

-- 
LISP is the most powerful programming language, and if you want an inter-
preter, LISP is the best.  None of the other languages come anywhere near
LISP in their power.  The most exciting things about LISP are read, eval,
and print.  If you look at other languages,  they have no equivalent for
any of those.                             -- Richard Stallman
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de


More information about the U-Boot mailing list