[U-Boot] [PATCH] arm:fix:cleanup: Volatile keyword removal

[Albert ARIBAUD]

Hi Lukasz,

Le 18/10/2011 16:25, Lukasz Majewski a écrit :
> Volatile keyword removal from
> ./arch/arm/include/asm/bitops.h
>
> Signed-off-by: Lukasz Majewski<l.majewski at samsung.com>
> Signed-off-by: Kyungmin Park<kyungmin.park at samsung.com>
> ---
>   arch/arm/include/asm/bitops.h |    6 +++---
>   1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/include/asm/bitops.h b/arch/arm/include/asm/bitops.h
> index 879e20e..b00ae30 100644
> --- a/arch/arm/include/asm/bitops.h
> +++ b/arch/arm/include/asm/bitops.h
> @@ -25,11 +25,11 @@
>   /*
>    * Function prototypes to keep gcc -Wall happy.
>    */
> -extern void set_bit(int nr, volatile void * addr);
> +extern void set_bit(int nr, void *addr);
>
> -extern void clear_bit(int nr, volatile void * addr);
> +extern void clear_bit(int nr, void *addr);
>
> -extern void change_bit(int nr, volatile void * addr);
> +extern void change_bit(int nr, void *addr);
>
>   static inline void __change_bit(int nr, volatile void *addr)
>   {

Going through backlogged patches adelegated to me, I found this one. I'm 
fine with it, however I notice there is absolutely no call to set_bit, 
change_bit or clear_bit in the whole ARM subtree... What is the point of 
removing only the volatile qualifier vs removing the function definitions?

Amicalement,
-- 
Albert.