[U-Boot] [PATCH] integrator: rewrite the AP PCI driver

Albert ARIBAUD albert.u.boot at aribaud.net
Sat Feb 18 16:26:21 CET 2012


Hi Linus,

Le 30/01/2012 19:36, Linus Walleij a écrit :
> The PCI support for the Integrator AP has apparently never
> been finished and I strongly suspect that it has never worked,
> so let's fix it. This is a list of the more or less
> un-splittable changes done in this driver rewrite:
>
> - Replace the register definitions stashed into the config
>    file (!) with a copy if the register file from the Linux
>    kernels arch/arm/include/asm/hardware/pci_v3.h
>
> - Delete the unreadable gigantic macros that perform the
>    config accesses and replace them with copyedited code from
>    Linux arch/arm/mach-integrator/pci_v3.c
>
> - Rewrite the rest of the setup code to use the
>    v3_[read|write][lwb]() accessors.
>
> - Enable PCI by default in the AP board configuration.
>
> - Fix checkpatch warnings and make code more conformant.
>
> Tested-by: Will Deacon<will.deacon at arm.com>
> Signed-off-by: Linus Walleij<linus.walleij at linaro.org>
> ---
>   board/armltd/integrator/pci.c    |  582 ++++++++++++++++++++++----------------
>   board/armltd/integrator/pci_v3.h |  200 +++++++++++++
>   include/configs/integratorap.h   |  148 +---------
>   3 files changed, 538 insertions(+), 392 deletions(-)
>   create mode 100644 board/armltd/integrator/pci_v3.h

Considering it is a bugfix that only touches boards maintained by yourself:

Applied to u-boot-arm/master, thanks.

Note: for some reason this patch appears twice in patchwork, with 
identical content and only different submission dates. I have rejected 
http://patchwork.ozlabs.org/patch/138700/ and accepted 
http://patchwork.ozlabs.org/patch/138700/ as rejected.

Amicalement,
-- 
Albert.


More information about the U-Boot mailing list