[U-Boot] [PATCH 2/4] arm: add %function attribute to assembly functions

Tom Rini trini at ti.com
Mon Feb 20 21:07:46 CET 2012


On Sun, Feb 19, 2012 at 02:15:30AM -0500, Mike Frysinger wrote:
> On Saturday 18 February 2012 17:03:59 Simon Glass wrote:
> > On Wed, Feb 15, 2012 at 5:57 AM, Aneesh V wrote:
> > > -.globl reset_cpu
> > > +.type  reset_cpu, %function
> > > +.global        reset_cpu
> > 
> > Should we introduce a macro to deal with this rather than writing it
> > out each time? EXPORT()?
> 
> we have it already with the linux/linkage.h header :)

Well, unless my tree is out of date (or stuff is in-flight) we don't
have the full compliment here.  We have <linux/linkage.h> for all and
<asm/linkage.h> for bfin.  That said, yes, we should grab at least the
ARM version and make use of ENTRY/END_FUNC ala the kernel.  I'm behind
on my "convert __attribute__((...)) to __attr" series already or I'd say
more :)

-- 
Tom


More information about the U-Boot mailing list