[U-Boot] [PATCH] mtd/nand:Fix wrong usage of is_blank() in fsl_ifc_run_command
Scott Wood
scottwood at freescale.com
Mon Feb 20 22:23:36 CET 2012
On Fri, Jan 20, 2012 at 06:38:14PM +0530, Prabhakar Kushwaha wrote:
> Freescale IFC NAND Machine calculates ECC on 512byte sector and same is used in
> fsl_ifc_run_command() during ECC status verification. Also this sector is passed
> to is_blank() for blank checking. It is wrong at first place because
> is_blank()'s implementation checks for Page size and OOB area size.
> is_blank() should be called per page for main and OOB area verification.
>
> Variables name are redefined to avoid confusion between buffer and ecc sector.
>
> Signed-off-by: Poonam Aggrwal <poonam.aggrwal at freescale.com>
> Signed-off-by: Scott Wood <scottwood at freescale.com>
> Signed-off-by: Prabhakar Kushwaha <prabhakar at freescale.com>
> ---
> Applied upon git://git.denx.de/u-boot.git (branch master)
>
> This patch is based upon ifc driver patch in linuxppc-dev mailing list
> http://patchwork.ozlabs.org/patch/136547/
>
> It is a replacement of my earlier patch
> "mtd/nand:Fix wrong address read in is_blank()"
> http://patchwork.ozlabs.org/patch/133388/
>
>
> drivers/mtd/nand/fsl_ifc_nand.c | 52 +++++++++++++++++++++------------------
> 1 files changed, 28 insertions(+), 24 deletions(-)
Applied to u-boot-nand-flash...
> + /*
> + * Uncorrectable error.
> + * OK only if the whole page is blank.
> + *
> + * We disable ECCER reporting due to...
> + * erratum IFC-A002770 -- so report it now if we
> + * see an uncorrectable error in ECCSTAT.
> + */
...with the "..." removed from the comment.
-Scott
More information about the U-Boot
mailing list