[U-Boot] [PATCH 0/9] Fix a few warnings that bug me

[Stefano Babic]

On 20/02/2012 19:49, Simon Glass wrote:
> Hi Wolfgang / Stefano,
> 

Hi Simon,

>> I just check that - actually my PowerPC one is v4.4.4:
>>
>> Using built-in specs.
>> Target: powerpc-linux
>> Configured with: /home/tony/buildall/src/gcc/configure
>> --target=powerpc-linux --enable-targets=all
>> --prefix=/opt/cross/gcc-4.4.4-nolibc/powerpc-linux/
>> --enable-languages=c --with-newlib --without-headers
>> --enable-sjlj-exceptions --with-system-libunwind --disable-nls
>> --disable-threads --disable-shared --disable-libmudflap
>> --disable-libssp --disable-libgomp --disable-decimal-float
>> --enable-checking=release --with-mpfr=/home/tony/buildall/src/sys
>> --with-gmp=/home/tony/buildall/src/sys
>> Thread model: single
>> gcc version 4.4.4 (GCC)
>>
>> I got this from Mike F (from the Gentoo site).
>>
> 
> What should we do about this series? I still see these warnings with
> the toolchains I use [1]. Does anyone else?

I read the whole thread, and it seems that it is not clear if the
warnings are real or must be related to the used toolchain.

I will try myself with mips, as this is one of the architectures
reporting warnings.

However, current toolchains based on more restrictive compilers
(I mean, GCC >= 4.6) seem to be happy with the code. At least a couple
of patches reassembles code that seems correct...

IMHO if the code cannot be built with an older toolchain we can try to
fix, and also we must drop warnings with newer and current toolchains (a
lot of patches fixed gcc 4.6 warnings). I am aware that we cannot
support every toolchain, even if we try to do it. And maybe (only my
opinion) it is acceptable to have some warnings with older toolchains.

So tendentially my vote is not to take these patches, but Wolfgang has
the last word on them.

Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================