[U-Boot] [PATCH 15/17] power: twl6035: add palmas PMIC support

[R, Sricharan]

Hi Tom,
On Mon, Feb 20, 2012 at 11:19 PM, Tom Rini <trini at ti.com> wrote:

> On Fri, Feb 17, 2012 at 05:35:31PM +0530, R Sricharan wrote:
>
> > From: Balaji T K <balajitk at ti.com>
> >
> > palmas/TWL6035 is power IC for omap5 evm boards
> >
> > Signed-off-by: Balaji T K <balajitk at ti.com>
> [snip]
> > +++ b/drivers/power/twl6035.c
> [snip]
> > +#ifdef CONFIG_TWL6035_POWER
>
> Don't need to do that since we only link this file when that is set.
>
> > +/* Functions to read and write from TWL6030 */
> > +int twl6035_i2c_write_u8(u8 chip_no, u8 val, u8 reg)
> > +{
> > +     return i2c_write(chip_no, reg, 1, &val, 1);
> > +}
> > +
> > +int twl6035_i2c_read_u8(u8 chip_no, u8 *val, u8 reg)
> > +{
> > +     return i2c_read(chip_no, reg, 1, val, 1);
> > +}
>
> Used, exported, OK.
>
> > +/* To align with i2c mw/mr address, reg, val command syntax */
> > +static inline int palmas_write_u8(u8 chip_no, u8 reg, u8 val)
> > +{
> > +     return i2c_write(chip_no, reg, 1, &val, 1);
> > +}
> > +
> > +static inline int palmas_read_u8(u8 chip_no, u8 reg, u8 *val)
> > +{
> > +     return i2c_read(chip_no, reg, 1, val, 1);
> > +}
>
> Unused and static so this must have warned.  To be clear, I expect the
> patch series to add no more warnings for omap5_evm.  Thanks!
>
>   Agree. This should be in the later patch.
  Will correct this in V2 as well.

> --
> Tom
>


Thanks,
 Sricharan