[U-Boot] [PATCH 0/9] Fix a few warnings that bug me

Stefano Babic sbabic at denx.de
Wed Feb 22 12:06:05 CET 2012


On 21/02/2012 19:40, Simon Glass wrote:

> Yes but not just those. There are detailed notes with each patch, but
> here is a summary. I think 6 out of 9 patches should be applied
> regardless of toolchain.
> 
> 68k only:
>  arch/m68k/lib/board.c               |    2 +-
> - I believe this fix is sensible for the reasons described in the
> patch, regardless of what the toolchain does.

Agree - I will send my ACK and merge it into my u-boot-staging

>  arch/powerpc/lib/board.c            |    7 +--
> - Similar to the68k patch, again I think it makes sense to apply this.
> The variable is unsigned char for no good reason.

Agree, there is no reason. I will merge also this one into u-boot-staging.

> 
> Sandbox:
>  arch/sandbox/cpu/os.c               |   11 +++--
> - This should be applied as it is not toolchain dependent (Mike may
> have picked it up already)

Ok, the patch has already found its way to mainline

> 
> ARM and PPC:
>  drivers/usb/host/ohci-hcd.c         |   26 ++++++------
> - These happen with my 4.4.4 compiler, apparently not on 4.6. Drop
> them if you like.
> 
> ARM:
>  include/configs/snapper9260.h       |    1 -
> - This fixes a real problem regardless of toolchain.

Right. I will send my ACK with CC to Albert. He can pick-up it directly
into u-boot-arm.

Best regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================


More information about the U-Boot mailing list