[U-Boot] [PATCH v3 5/6] omap4+: Avoid using __attribute__ ((__packed__))

Tom Rini trini at ti.com
Thu Feb 23 15:21:00 CET 2012


On Thu, Feb 23, 2012 at 7:06 AM, Aneesh V <aneesh at ti.com> wrote:
> Avoid using __attribute__ ((__packed__)) unless it's
> absolutely necessary. "packed" will remove alignment
> requirements for the respective objects and may cause
> alignment issues unless alignment is also enforced
> using a pragma.
>
> Here, these packed attributes were causing alignment
> faults in Thumb build.
>
> Signed-off-by: Aneesh V <aneesh at ti.com>

Why did we pack these to start with?  Otherwise seems fine (and I see
the rest of the TI parts don't have this particular packing).

-- 
Tom


More information about the U-Boot mailing list