[U-Boot] [PATCH v2 3/5] ARM: enable Thumb build

[Mike Frysinger]

On Thursday 23 February 2012 08:39:43 Aneesh V wrote:
> --- a/arch/arm/config.mk
> +++ b/arch/arm/config.mk
> 
> -# Explicitly specifiy 32-bit ARM ISA since toolchain default can be
> -mthumb: +# Choose between ARM/Thumb instruction sets
> +ifeq ($(CONFIG_SYS_THUMB_BUILD),y)
> +PF_CPPFLAGS_ARM := $(call cc-option, -mthumb -mthumb-interwork,\
> +			$(call cc-option,-marm,)\
> +			$(call cc-option,-mno-thumb-interwork,)\
> +		)
> +else
>  PF_CPPFLAGS_ARM := $(call cc-option,-marm,)
> +PF_CPPFLAGS_ARM += $(call cc-option,-mno-thumb-interwork,)

this 2nd part is no good.  "+=" is not the same thing as ":=".

might be simpler to do:
PF_CPPFLAGS_MARM := $(call cc-option,-marm)
PF_CPPFLAGS_THUMB := $(call cc-option,-mthumb -mthumb-interwork)
PF_CPPFLAGS_NO_THUMB := $(call cc-option,-mno-thumb-interwork)

ifeq ($(CONFIG_SYS_THUMB_BUILD),y)
PF_CPPFLAGS_ARM = $(PF_CPPFLAGS_THUMB)
else
PF_CPPFLAGS_ARM = $(PF_CPPFLAGS_MARM) $(PF_CPPFLAGS_NO_THUMB)
endif
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120223/00fef8a1/attachment.pgp>