[U-Boot] [PATCH v3 1/6] arm: adapt asm/linkage.h from Linux

[Mike Frysinger]

On Thursday 23 February 2012 12:40:54 Aneesh V wrote:
> On Thursday 23 February 2012 08:29 PM, Mike Frysinger wrote:
> > On Thursday 23 February 2012 09:06:01 Aneesh V wrote:
> >> --- /dev/null
> >> +++ b/arch/arm/include/asm/linkage.h
> >> @@ -0,0 +1,11 @@
> >> +#ifndef __ASM_LINKAGE_H
> >> +#define __ASM_LINKAGE_H
> > 
> > needs copyright/license comment header
> 
> As Tom mentioned, I don't know whose copyright it is.

sorry, i assumed you were creating it from scratch

> >> +#define ENDPROC(name) \
> >> +.type name, %function; \
> >> +END(name)
> > 
> > please change linux/linkage.h instead.  % should be safe for everyone.
> 
> The spec says that STT_FUNC will work for all archs. How about using
> that?

i'd prefer to use %function in the common code, but i won't fight too hard.  
reading gas/config/obj-elf.c seems to back up your STT_FUNC claims; it's just 
that i've found @function/%function to be much more common in practice than 
using STT_FUNC.  i've only see the latter in more esoteric code ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120223/a5ed6fc6/attachment.pgp>