[U-Boot] [PATCH] ARM: Define change_bit routine

Amit Virdi amit.virdi at st.com
Wed Feb 29 06:21:55 CET 2012


Hello Albert,

On 2/29/2012 4:49 AM, Albert ARIBAUD wrote:
> Hi Amit,
>
> Le 27/02/2012 10:33, Amit Virdi a écrit :
>> From: Vipin KUMAR<vipin.kumar at st.com>
>>
>> change_bit routine is left implementation dependent until now.
>> This routine is now defined for arm platforms in asm-arm/bitops.h
>>
>> The Flexible Static memory controller driver, placed in
>> mtd/nand/fsmc_nand.c needs this routine. FSMC is a memory controller
>> peripheral from ST. The new driver implements the NAND interface part
>> of the peripheral.
>>
>> Signed-off-by: Vipin Kumar<vipin.kumar at st.com>
>> Signed-off-by: Amit Virdi<amit.virdi at st.com>
>> ---
>>    arch/arm/include/asm/bitops.h |   11 +++++++++--
>>    1 files changed, 9 insertions(+), 2 deletions(-)
>
> NAK as this is submitted as an isolated patch to dead code.
>
> Provide it as a member of a patchset where some later patch uses it --
> and justify that you really need this function.
>

Ok. change_bit routine is used by FSMC driver. I should be re-sending it 
as a part of FSMC driver patchset.

Regards
Amit Virdi


More information about the U-Boot mailing list