[U-Boot] [RFC PATCH 0/19] Create generic board init and move ARM and x86 to it

Simon Glass sjg at chromium.org
Tue Jan 3 06:28:50 CET 2012


Hi Graham,

On Mon, Jan 2, 2012 at 3:26 AM, Graeme Russ <graeme.russ at gmail.com> wrote:
> Hi Simon,
>
> In case you haven't noticed (I did not Cc you or Wolfgang, sorry 'bout
> that) I've posted the cleaned up version of my x86 init refactoring...

Yes I see it - thats great thanks. I will go through it and compare.

[big snip]

>
>> functions. Now this is better than where we are now, but my original
>> complaint was that I want to be able to add features to a single place
>> and have them work across all architectures. With your end-result I
>> still need to figure out where to put the new feature in each initcall
>> list and create 10 patches, one for each arch, to plumb it in.
>
> Agree, and my ultimate end goal (as per my previous initcall patch series)
> is to remove the per-arch init list as well...

Well since it seems we are going for the same goal, and you are
actively submitting patches towards it, I'm very happy. I mostly agree
with your points, so will not respond bit by bit. The easiest route to
the goal is the right one, so let's run with what you propose and see
how we go. Thanks for taking it up.

[another big snip]

I had a go at bringing PPC into the generic board patches. Apart from
the cloud of #ifdefs as expected it is not too bad. And those can be
dealt with by initcalls.

Am hoping we can get there soon!

Regards,
Simon

> Regards,
>
> Graeme


More information about the U-Boot mailing list