[U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

Sughosh Ganu urwithsughosh at gmail.com
Wed Jan 11 16:09:53 CET 2012


On Wed Jan 11, 2012 at 04:01:31PM +0100, Marek Vasut wrote:

> >   More so, given the fact that we don't have any control over
> >   rbl -- so if rbl changes it's layout for any subsequent board, we'd
> >   have to add that as well to the nand driver, and both in u-boot as
> >   well as the kernel.
> > 
> >   I guess the cleanest solution would have been for the rbl to have
> >   used the same layout as the one used by u-boot and linux.
> 
> Yep, why not do that then?

  Because rbl is a proprietary bootloader from TI.

> > 
> >   Btw, can you please review this change, that this patch
> >   fixes. ACK/NAK?
> 
> I'll think about it. It's ok, but it piles one workaround on top of another one, 
> I don't like that approach.

  Flushing the data cache before disabling it is not a workaround,
  it's a fix. The current code is invalidating the cache instead of
  flushing it.

-sughosh


More information about the U-Boot mailing list