[U-Boot] [PATCH V3 2/2] ARM: omap3: add support to Technexion twister board

[Albert ARIBAUD]

Hi Stefano,

Le 14/01/2012 10:48, Stefano Babic a écrit :
> On 14/01/2012 09:47, Albert ARIBAUD wrote:
>> (re-sent due to the U-Boot MX rejecting my provider's servers -- again)
>>
>> Hi Stefano,
>>
>
> Hi Albert, hi Tom,
>
>>> drivers/usb/host/libusb_host.o: In function `usb_lowlevel_init':
>>> /home/uboot/src/u-boot-arm/drivers/usb/host/ehci-hcd.c:814: undefined
>>> reference to `ehci_hcd_init'
>
> The twister board depends on several patches for the AM3517 processor
> previously senty by Ilya Yanok. One of them (maybe because it is USB
> related and should go into u-boot-usb) is missing.
>
> http://patchwork.ozlabs.org/patch/130952/

Board then compiles but with warnings for 4 declared but unused symbols.

> The patch is set to new and assigned to Remy, but he gived up as
> maintainer - nobody checks at it ;-(.

Considering that all it does is adding a new EHCI driver, the worst 
impact it can have is to not function properly for boards using it, 
which at the moment means omap3_beagle and tam3517; but it won't affect 
USB on existing boards.

But then I wonder why twister needs it at all, as it does not have a 
single USB config option in its header config file...

> I can at least sent my tested-by - it was nice if you can pick it up.

*If* someone can explain to me why a patch that adds a new USB EHCI 
driver is needed by a board which does not have any "USB" in its config 
header file, and *unless Wolfgang says otherwise*, I agree to accept 
patch 130952 with your Tested-By.

> Best regards,
> Stefano

Amicalement,
-- 
Albert.