[U-Boot] [PATCH] net/eth.c: fix eth_write_hwaddr() to use dev->enetaddr as fall back

[Wolfgang Denk]

Dear Philip Balister,

In message <4F142F52.508 at balister.org> you wrote:
>
> > I'm not going to pull that patch.
> > 
> > Please explain which actual problem you're trying to fix.
> 
> For u-boot for an overo based product that uses the SMSC911x ethernet
> chip (with MAC address set via EEPROM connected to the SMSC911x chip) I
> have a local patch to prevent u-boot from printing:
> 
> Warning: failed to set MAC address

Something went wrong here.  Either you should not run the operation
that failed, or you should find out why it failed and fixe the cause
of that.

> The MAC address is still OK and we basically removed the code that led
> to the message to reduce customer confusion :)

Papering over errors or warnings is rarely a good thing.  We should
understand what happened and fix the original cause of the problem
instead.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I wrote my name at the top of the page. I wrote down  the  number  of
the  question  ``1''.  After much reflection I put a bracket round it
thus ``(1)''. But thereafter I could not think of anything  connected
with it that was either relevant or true.
                        - Sir Winston Churchill _My Early Life_ ch. 2