[U-Boot] [PATCH] net/eth.c: fix eth_write_hwaddr() to use dev->enetaddr as fall back

[Philip Balister]

On 01/13/2012 02:19 PM, Wolfgang Denk wrote:
> Dear Eric Miao,
> 
> In message <1313559224-4627-1-git-send-email-eric.miao at linaro.org> you wrote:
>> Ignore the return value of eth_getenv_enetaddr_by_index(), and if it
>> fails, fall back to use dev->enetaddr, which could be filled up by
>> the ethernet device driver.
>>
>> Actually, this is the original behavior, and was later changed by
>> commit 48506a2cde2458fa1f8c5993afc98e5a4617e1d3.
> 
> I'm not going to pull that patch.
> 
> Please explain which actual problem you're trying to fix.
> 

For u-boot for an overo based product that uses the SMSC911x ethernet
chip (with MAC address set via EEPROM connected to the SMSC911x chip) I
have a local patch to prevent u-boot from printing:

Warning: failed to set MAC address

The MAC address is still OK and we basically removed the code that led
to the message to reduce customer confusion :)

Hopefully, the patch people are talking about here is a proper fix to
this problem.

Philip


> Also, fix the commit ID - the one you list above does not exist in
> mainline.
> 
> Best regards,
> 
> Wolfgang Denk
>