[U-Boot] [PATCH 02/28] net: cosmetic: checkpatch compliance

[Simon Glass]

Hi Joe,

On Fri, Jan 20, 2012 at 12:21 PM, Joe Hershberger
<joe.hershberger at gmail.com> wrote:
> Hi Simon,
>
> On Fri, Jan 20, 2012 at 10:30 AM, Simon Glass <sjg at chromium.org> wrote:
>> Hi Joe,
>>
>> On Thu, Jan 19, 2012 at 4:53 PM, Joe Hershberger <joe.hershberger at ni.com> wrote:
>>> Signed-off-by: Joe Hershberger <joe.hershberger at ni.com>
>>> Cc: Joe Hershberger <joe.hershberger at gmail.com>
>>> Cc: Wolfgang Denk <wd at denx.de>
>>> ---
>>>  common/main.c            |    1 -
>>>  drivers/net/netconsole.c |  122 +++++++++--------
>>>  include/common.h         |    4 +
>>>  include/net.h            |  123 +++++++++--------
>>>  net/bootp.c              |  338 +++++++++++++++++++++++-----------------------
>>>  net/bootp.h              |   56 ++++----
>>>  net/eth.c                |   66 +++++-----
>>>  net/net.c                |   19 +--
>>>  net/nfs.c                |  300 ++++++++++++++++++++---------------------
>>>  net/nfs.h                |    2 +-
>>>  net/rarp.c               |   28 ++--
>>>  net/rarp.h               |    4 +-
>>>  net/sntp.c               |   31 +++--
>>>  net/sntp.h               |    2 +-
>>>  net/tftp.c               |   30 ++---
>>>  net/tftp.h               |    2 +-
>>>  16 files changed, 572 insertions(+), 556 deletions(-)
>>>
>>
>> Others may fine with it, but it might be worth splitting this very
>> long patch, perhaps split out some of the larger files or the
>> show_activity() change.
>
> I had this separated by file, but figured since the series was pretty
> long, it is all cosmetic (making separate patches not especially
> helpful), and it was under the 100kB mail limit that it would be
> better as a single patch.  If it will be a barrier to review, I can
> split it up again.

I'm not sure if it is a barrier to review or not, but I did nod off
about 15% through :-)

Regards,
Simon

>
> Best regards,
> -Joe