[U-Boot] [PATCH] armv7: Fix to mistake clean the memory space

Zhong Hongbo bocui107 at gmail.com
Fri Jul 6 16:04:21 CEST 2012


On 07/06/2012 09:57 PM, Andreas Bießmann wrote:
> Dear Zhong Hongbo,
> 
> On 06.07.2012 15:50, Zhong Hongbo wrote:
>> On 07/06/2012 09:23 PM, Andreas Bießmann wrote:
>>> On 06.07.2012 14:20, Zhong Hongbo wrote:
>>>> From: Zhong Hongbo <bocui107 at gmail.com>
>>>>
>>>> In currently, when __bss_start is equal to __bss_end__,
>>>> The bss loop will clear all the things in memory space.
>>>>
>>>> But just only when __bss_end__ greater than __bss_start__,
>>>> we do the clear bss section operation.
>>>>
>>>> Signed-off-by: Hongbo Zhong <bocui107 at gmail.com>
>>>> Signed-off-by: Andreas Bießmann <andreas.devel at googlemail.com>
>>>
>>> well this is wrong, I would maybe ack it
>>
>> Ok
> 
> After sending I doubt my statement was correct, but I found a source
> http://www.denx.de/wiki/view/U-Boot/Patches#Review_Process_Git_Tags

he, Ye, I think we(You, Albert and me) are involved in the development
of the patch.
> 
>>>
>>>> Signed-off-by: Albert ARIBAUD <albert.u.boot at aribaud.net>
>>>> ---
>>>
>>> Some more formal things ...
>>>
>>> This is the third version of this type of patch. Therefore it should
>>> have a version history here and some version information in the subject
>>> ([PATCH v3] maybe). Please read http://www.denx.de/wiki/view/U-Boot/Patches
>>> especially
>>> http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions
>>>
>>
>> Thanks, I just see the format of patch. I will add the version
>> information to the next review.
>>
>>> BTW: The content looks sane.
>>>
>>
>> I will send v3 for this.
> 
> a last formal thing to mention: The subject should (now) say 'arm: ...'
> not 'armv7: ...'.

Ok.

Thanks,
hongbo
> 
> Best regards
> 
> Andreas Bießmann
> 
> 




More information about the U-Boot mailing list