[U-Boot] [PATCH] armv7: Fix to mistake clean the memory space

Albert ARIBAUD albert.u.boot at aribaud.net
Fri Jul 6 17:26:17 CEST 2012


Hi Zhong Hongbo,

On Fri, 06 Jul 2012 22:04:21 +0800, Zhong Hongbo <bocui107 at gmail.com>
wrote:
> On 07/06/2012 09:57 PM, Andreas Bießmann wrote:
> > Dear Zhong Hongbo,
> > 
> > On 06.07.2012 15:50, Zhong Hongbo wrote:
> >> On 07/06/2012 09:23 PM, Andreas Bießmann wrote:
> >>> On 06.07.2012 14:20, Zhong Hongbo wrote:
> >>>> From: Zhong Hongbo <bocui107 at gmail.com>
> >>>>
> >>>> In currently, when __bss_start is equal to __bss_end__,
> >>>> The bss loop will clear all the things in memory space.
> >>>>
> >>>> But just only when __bss_end__ greater than __bss_start__,
> >>>> we do the clear bss section operation.
> >>>>
> >>>> Signed-off-by: Hongbo Zhong <bocui107 at gmail.com>
> >>>> Signed-off-by: Andreas Bießmann <andreas.devel at googlemail.com>
> >>>
> >>> well this is wrong, I would maybe ack it
> >>
> >> Ok
> > 
> > After sending I doubt my statement was correct, but I found a source
> > http://www.denx.de/wiki/view/U-Boot/Patches#Review_Process_Git_Tags
> 
> he, Ye, I think we(You, Albert and me) are involved in the development
> of the patch.

It could be said of any reviewer that they are "involved in the
development of the patch", yet not all reviewers's Signed-off-by is
added to evey patch they review. There is a Reviewed-by tag for
reviewers.

I personally do not consider it would make sense to have my
Signed-off-by on this patch.

Amicalement,
-- 
Albert.


More information about the U-Boot mailing list