[U-Boot] [PATCH 2/5] ehci-hcd: Boost transfer speed

Marek Vasut marex at denx.de
Fri Jul 27 16:31:36 CEST 2012


Dear Benoît Thébaudeau,

> Dear Marek,
> 
> On Fri, Jul 27, 2012 at 04:01:11 PM, Marek Vasut wrote:
> > > Do you think
> > > using PAGE_SIZE from <linux/compat.h> would be fine since these
> > > 4096 are
> > > nothing more than page sizes?
> > 
> > Isn't that intel-specific?
> 
> I don't know. The code does not say so. What is sure is that page sizes
> should be arch-specific, even with several possible page sizes per arch.
> But this #define seems to fit our needs, so why not use it? The only thing
> that would make me reluctant to using it is that this code might change
> without further notice.

That's exactly my point. And it'll break anything with pages smaller than 4k. 
Please define it in ehci.h
[..]
Best regards,
Marek Vasut


More information about the U-Boot mailing list