[U-Boot] [PATCH 2/5] ehci-hcd: Boost transfer speed

Benoît Thébaudeau benoit.thebaudeau at advansee.com
Sun Jul 29 02:58:01 CEST 2012


Dear Marek,

On Fri, Jul 27, 2012 at 04:13:45 PM, Benoît Thébaudeau wrote:
> On Fri, Jul 27, 2012 at 04:01:11 PM, Marek Vasut wrote:
> > [...]
> > > > > +			token = (toggle << 31) |
> > > > > +			    (xfr_bytes << 16) |
> > > > > +			    ((req == NULL ? 1 : 0) << 15) |
> > > > > +			    (0 << 12) |
> > > > > +			    (3 << 10) |
> > > > > +			    ((usb_pipein(pipe) ? 1 : 0) << 8) | (0x80 << 0);
> > > > 
> > > > If you could fix all this magic afterwards (not in these
> > > > patches),
> > > > that'd be
> > > > great.
> > > 
> > > Do you only mean #defining all those values?
> > 
> > Yes, but let's do this in a subsequent patch. It can wait for
> > later.
> 
> OK.

What would you think about merging that together with the definition of 4096
into the current patch 1/5? In the next version, this patch would thus become a
general cosmetic patch for EHCI to define all used constants.

Best regards,
Benoît


More information about the U-Boot mailing list