[U-Boot] [PATCH] dm: ppc: Fixup cpu.c warning in mpc8xx

Wolfgang Denk wd at denx.de
Sat Jul 28 00:14:36 CEST 2012


Dear Marek,

In message <201207272326.26896.marex at denx.de> you wrote:
>
> > > -	k = (immr << 16) | *((ushort *) & immap->im_cpm.cp_dparam[0xB0]);
> > > +	k = (immr << 16) | readw(&immap->im_cpm.cp_dparam[0xB0]);
> > 
> > I think this is wrong.  readw() is a little endian I/O accessor, but
> > PPC is all big-endian.
>
> So in_be32 it is, I guess?

Wrong again. Looks more like in_be16 to me...

> > Guess this was untested?
>
> Of course it was not. Had trouble even sending this via the crappy cellular>  
> connection on a train ;-)

You tested it? And it worked?  I'm surprised. ...  Really??

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Worlds are conquered, galaxies destroyed -- but a woman is  always  a
woman.
	-- Kirk, "Conscience of the King", stardate unknown


More information about the U-Boot mailing list