[U-Boot] [PATCH] dm: ppc: Fixup cpu.c warning in mpc8xx

Marek Vasut marex at denx.de
Sat Jul 28 00:29:32 CEST 2012


Dear Wolfgang Denk,

> Dear Marek,
> 
> In message <201207272326.26896.marex at denx.de> you wrote:
> > > > -	k = (immr << 16) | *((ushort *) & immap-
>im_cpm.cp_dparam[0xB0]);
> > > > +	k = (immr << 16) | readw(&immap->im_cpm.cp_dparam[0xB0]);
> > > 
> > > I think this is wrong.  readw() is a little endian I/O accessor, but
> > > PPC is all big-endian.
> > 
> > So in_be32 it is, I guess?
> 
> Wrong again. Looks more like in_be16 to me...

Ok, lemme try V2.

> > > Guess this was untested?
> > 
> > Of course it was not. Had trouble even sending this via the crappy
> > cellular> connection on a train ;-)
> 
> You tested it? And it worked?  I'm surprised. ...  Really??

No, I did not test it. The train control unit is MPC5200 too ... so I really had 
no hardware to test it on in close proximity ;-)

> Best regards,
> 
> Wolfgang Denk

Best regards,
Marek Vasut


More information about the U-Boot mailing list