[U-Boot] [PATCH 3/4] OMAP3: twister: add video support

[Stefano Babic]

On 21/06/2012 03:15, Tom Rini wrote:
> On Thu, Jun 14, 2012 at 10:29:47AM +0200, Stefano Babic wrote:
> 

Hi Tom,

>> Signed-off-by: Stefano Babic <sbabic at denx.de>
> [snip]
>> +static GraphicDevice panel;
>> +static const struct panel_config lcd_cfg = {
>> +	.timing_h	= 0x01101d1b, /* Horizontal timing */
>> +	.timing_v	= 0x01400b02, /* Vertical timing */
>> +	.pol_freq	= 0x00023000, /* Pol Freq */
>> +	.divisor	= 0x0001000d, /* 33Mhz Pixel Clock */
>> +	.lcd_size	= ((YRES - 1) << 16 | (XRES - 1)),
>> +	.panel_type	= 0x01, /* TFT */
>> +	.data_lines	= 0x03, /* 24 Bit RGB */
>> +	.load_mode	= 0x02 /* Frame Mode */
>> +};
> 
> You need #if defined(CONFIG_VIDEO) && !defined(CONFIG_SPL_BUILD)
> type testing here[1] that the mt_ventoux board patch has.  Shall I or
> will you v2?  And I'll sanity test this on omap3_beagle tomorrow, but I
> suspect it's fine :)

I discussed with Anatolji about the patches and they need to be rebased
and reworked - a v2 is necessary !

Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================