[U-Boot] [PATCH] [PATCH] net/eth.c: Avoid Warning when ethxaddr is not set

Wolfgang Denk wd at denx.de
Sat Mar 3 16:11:21 CET 2012

Dear "gwenhael.goavec",

In message <20120303155719.3ae222cc at trabucayre.com> you wrote:
> > Which use case do you have in mind?  Why do you think this warning is
> > bad?  I tend to consider it helpful instead.
> For boards with mac address stored on an eeprom for example, the variable
> ethaddr is not needed. But with this test, a warning is always shown, without
> any reason.

The environment variable is always mandatory.  If it does not exist,
or if it's value is different from the one stored somewhere else, a
warning shall be issued (and the environment value takes precedence).

So I think current behaviour is actually correct.

Best regards,

Wolfgang Denk

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In the beginning, there was nothing, which exploded.
                                - Terry Pratchett, _Lords and Ladies_

More information about the U-Boot mailing list